mobile: Keep selection on tap and hold#6208
Draft
MaxGyver83 wants to merge 1 commit into
Draft
Conversation
andydotxyz
reviewed
Mar 18, 2026
Member
andydotxyz
left a comment
There was a problem hiding this comment.
I haven't run the code but it looks like this removes reporting of the mobile "TouchDown". That is not connected to the Tapped handler and must go to any widget interested.
Contributor
Author
It's true: I think, there are two solutions to the problem in the description:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
With this PR, a click happens only after the finger is released because at the moment of touching the screen, you can't know if the user is going to perform a regular (short) or a secondary (long) tap.
I'm still unsure if this breaks anything. At least the demo app seems to behave normal when compiled with
-tags=mobile.Fixes #6207.
Checklist:
Where applicable: