Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add docs about field removal #7049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

Add docs about field removal #7049

merged 1 commit into from
Nov 23, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR proposes the process for removing a field. Inspired by upstream changes for field removal such as kubernetes/kubernetes#102412.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
I am creating the PR in draft state as the referenced PR (#6972) as example is not yet merged.

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 21, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 21, 2022
@gardener-prow gardener-prow bot requested review from timebertt and timuthy November 21, 2022 15:07
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2022
timebertt
timebertt reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a valuable addition!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@ialidzhikov ialidzhikov marked this pull request as ready for review November 23, 2022 08:55
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
rfranzke
rfranzke reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds great!

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@gardener-prow gardener-prow bot merged commit e0fc23e into gardener:master Nov 23, 2022
@ialidzhikov ialidzhikov deleted the doc/field-removal branch November 28, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timebertt timebertt timebertt left review comments

@timuthy timuthy Awaiting requested review from timuthy

@acumino acumino Awaiting requested review from acumino

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

Assignees

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @rfranzke @timebertt