Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(showcase): Add Saobear's blog #20115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2019
Merged

chore(showcase): Add Saobear's blog #20115

merged 4 commits into from
Dec 16, 2019

Conversation

PiccoloYu
Copy link
Contributor

I turned my blog into a startup project。

repo: https://github.com/PiccoloYu/SaoBear-is-Blog
Demo site (in Chinese): https://saobear.online/

@PiccoloYu PiccoloYu requested a review from a team as a code owner December 13, 2019 08:12
@lannonbr lannonbr changed the title I turned my blog into a startup project。 chore(showcase): Add Saobear's blog Dec 13, 2019
laurieontech
laurieontech reviewed Dec 13, 2019
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like a really fun site.

I noticed that the README for the git repo doesn't have instructions for running the site. Would you mind updating that to include something like the instructions found here? https://github.com/gatsbyjs/gatsby-starter-default

docs/sites.yml Outdated
@@ -8946,3 +8946,11 @@
built_by: n8tb1t
built_by_url: https://github.com/n8tb1t/
featured: false
- title: SaoBear's-Blog
main_url: "https://saobear.online/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
main_url: "https://saobear.online/"
main_url: https://saobear.online/

docs/sites.yml Outdated
@@ -8946,3 +8946,11 @@
built_by: n8tb1t
built_by_url: https://github.com/n8tb1t/
featured: false
- title: SaoBear's-Blog
main_url: "https://saobear.online/"
url: "https://saobear.online/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: "https://saobear.online/"
url: https://saobear.online/

docs/sites.yml Outdated
- title: SaoBear's-Blog
main_url: "https://saobear.online/"
url: "https://saobear.online/"
source_url: "https://github.com/PiccoloYu/SaoBear-is-Blog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source_url: "https://github.com/PiccoloYu/SaoBear-is-Blog"
source_url: https://github.com/PiccoloYu/SaoBear-is-Blog

@PiccoloYu
Copy link
Contributor Author

PiccoloYu commented Dec 16, 2019 •
edited
Loading

I have corrected the original error and added a description file. Thank. @laurieontech

@laurieontech
Copy link
Contributor

Thanks for making the changes! Merging now.

@laurieontech laurieontech reopened this Dec 16, 2019
@laurieontech laurieontech merged commit 04dbcf7 into gatsbyjs:master Dec 16, 2019
@gatsbot
Copy link

gatsbot bot commented Dec 16, 2019

Holy buckets, @PiccoloYu — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiccoloYu @laurieontech @lannonbr