Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(showcase): add Futrli and Inventia #23330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2020
Merged

chore(showcase): add Futrli and Inventia #23330

merged 4 commits into from
Apr 29, 2020

Conversation

haydenbleasel
Copy link
Contributor

Description

Add Jellypepper client sites (Futrli and Inventia) to Showcase.

@haydenbleasel haydenbleasel requested a review from a team as a code owner April 21, 2020 02:12
@haydenbleasel haydenbleasel changed the title Add jellypepper sites Add Futrli and Inventia to Showcase Apr 21, 2020
@Hyraze Hyraze self-requested a review April 22, 2020 10:32
@Hyraze Hyraze changed the title Add Futrli and Inventia to Showcase chore(showcase): add Futrli and Inventia Apr 22, 2020
@Hyraze Hyraze removed their request for review April 22, 2020 10:50
Ekwuno
Ekwuno previously approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in.

@Hyraze Hyraze self-requested a review April 22, 2020 15:58
Hyraze
Hyraze previously approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@Hyraze Hyraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!!

Hyraze
Hyraze reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@Hyraze Hyraze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push the commit to resolve the conflict @haydenbleasel

@haydenbleasel haydenbleasel dismissed stale reviews from Hyraze and Ekwuno via c49574d April 24, 2020 06:40
@haydenbleasel
Copy link
Contributor Author

@Hyraze Not sure if I did that correctly, sorry if not :S

@gatsbybot
Copy link
Collaborator 

docs/sites.yml: SyntaxError: Map keys must be unique; "built_by_url" is repeated (10457:3)
   10455 |     - Business
   10456 |   built_by: GeneOS Team
 > 10457 | - title: COVID KPI
         |   ^^^^^^^^^^^^^^^^
 > 10458 |   url: https://covidkpi.com/
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10459 |   main_url: https://covidkpi.com/
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10460 |   description: >
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10461 |     COVID KPI aggregates COVID-19 data from numerous official sources then displays the Key Performance Indicators.
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10462 |   categories:
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10463 |     - Data
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10464 |     - Media
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10465 |     - Healthcare
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10466 |   built_by: Albert Chen
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10467 |   built_by_url: https://github.com/mralbertchen
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10468 |   built_by_url: https://github.com/mralbertchen
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 10469 | - title: Sztuka Programowania
         | ^
   10470 |   built_by: Piotr Fedorczyk
   10471 |   built_by_url: https://piotrf.pl
   10472 |   categories:

@Ekwuno
Copy link
Contributor

Ekwuno commented Apr 28, 2020

@haydenbleasel gatsbybot is picking out an error in your submission, it seems that the builtbyURL already exists in the doc/site.yml. For a submission about COVID KPI. Can you remove the builtbyURL in this submission?

Ekwuno
Ekwuno approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rectifying the issue with gatsbybot. I will get this merged in.

@Ekwuno Ekwuno merged commit c07894a into gatsbyjs:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyraze Hyraze Hyraze left review comments

@Ekwuno Ekwuno Ekwuno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haydenbleasel @gatsbybot @Ekwuno @Hyraze