Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(docs): updated doc for payment using square #27272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2021
Merged

chore(docs): updated doc for payment using square #27272

merged 2 commits into from
Mar 1, 2021

Conversation

imshubhamsingh
Copy link
Contributor

This pull request addresses issue #26055

In this PR, I've

  1. Updated the Doc describing the details of implementing payment using square
  2. Implemented backend using netlify lambda for successful payment
  3. Updated the dependencies for the example project.

Feel free to provide feedback. Looking forward to it.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 4, 2020
@LekoArts LekoArts added hacktoberfest-accepted type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 5, 2020
@LekoArts
Copy link
Contributor

LekoArts commented Oct 5, 2020

Hi, thanks for the PR! I think you'll want to revert the changes to the example as #27263 addresses this :)

@imshubhamsingh
Copy link
Contributor Author

@LekoArts should I close the PR as I think this is addressed in #27263 ?

@LekoArts
Copy link
Contributor

LekoArts commented Oct 5, 2020

Since @jonniebigodes isn't changing the docs portion of it, you can make the requested changes for that file :) So no need to close this PR!

@imshubhamsingh
Copy link
Contributor Author

@LekoArts thanks. Sure I'll update PR accordingly then. Thanks ✌️

@pvdz pvdz changed the title updated the example and doc for payment using square chore(docs): updated the example and doc for payment using square Oct 5, 2020
@pvdz pvdz mentioned this pull request Oct 5, 2020
Closed
@pvdz
Copy link
Contributor

pvdz commented Oct 5, 2020

(-> #27263 ?)

@imshubhamsingh imshubhamsingh force-pushed the docs/payment-with-square branch 2 times, most recently from b1c164f to 507c751 Compare October 5, 2020 12:12
@imshubhamsingh
Copy link
Contributor Author

@LekoArts I've updated the Doc. Rest of the changes are removed.

@imshubhamsingh imshubhamsingh force-pushed the docs/payment-with-square branch from 507c751 to 0f5f626 Compare October 6, 2020 13:54
@imshubhamsingh
Copy link
Contributor Author

@pvdz I've updated the doc. Let me know if I missed something.

@imshubhamsingh imshubhamsingh changed the title chore(docs): updated the example and doc for payment using square chore(docs): updated doc for payment using square Oct 8, 2020
pvdz
pvdz approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💜

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 4, 2021
@wardpeet wardpeet merged commit 002aae6 into gatsbyjs:master Mar 1, 2021
@imshubhamsingh imshubhamsingh mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pvdz pvdz pvdz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imshubhamsingh @LekoArts @pvdz @wardpeet