Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(gatsby-plugin-image): Fix onload race condition #29064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix(gatsby-plugin-image): Fix onload race condition #29064

merged 1 commit into from
Jan 18, 2021

Conversation

ascorbic
Copy link
Contributor

We previously removed the onload listener if any image had already been hydrated. This was causing a race condition where it was removed before some images had loaded.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 18, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 18, 2021
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 18, 2021
@gatsbybot gatsbybot merged commit 6233382 into master Jan 18, 2021
@gatsbybot gatsbybot deleted the fix/fixed-ssr-onload branch January 18, 2021 12:18
This was referenced Jan 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@saurabharch saurabharch mentioned this pull request Jan 21, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Jan 31, 2021
Open
This was referenced Jan 1, 2024
Open
Open
This was referenced Jan 1, 2024
Open
Open
Open
@wizbit wizbit mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 2, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 2, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 2, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 15, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Mar 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Mar 15, 2024
Open
This was referenced Mar 15, 2024
Open
Open
Open
@monizb monizb mentioned this pull request Mar 16, 2024
Open
This was referenced Mar 16, 2024
Open
Open
Open
@joeawillis joeawillis mentioned this pull request Mar 16, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Mar 16, 2024
Open
@joeawillis joeawillis mentioned this pull request Mar 18, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 22, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pvdz pvdz pvdz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascorbic @pvdz @gatsbybot