Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(gatsby): queue fs writes so event loop not overwhelmed on large sites #29219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 27, 2021
Merged

fix(gatsby): queue fs writes so event loop not overwhelmed on large sites #29219

merged 9 commits into from
Jan 27, 2021

Conversation

KyleAMathews
Copy link
Contributor

Dropped write time for 100k create-pages benchmark from 69s -> 15s for a ~78% decrease

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 26, 2021
@KyleAMathews KyleAMathews added topic: scaling builds and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 26, 2021
@KyleAMathews KyleAMathews requested review from pieh and vladar January 27, 2021 04:40
KyleAMathews
KyleAMathews commented Jan 27, 2021
View reviewed changes
vladar
vladar reviewed Jan 27, 2021
View reviewed changes
pieh
pieh approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 thanks!

@KyleAMathews KyleAMathews merged commit 7c38997 into master Jan 27, 2021
@KyleAMathews KyleAMathews deleted the queue-file-writes branch January 27, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

+1 more reviewer

@vladar vladar vladar left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleAMathews @vladar @pieh