feat(babel-preset-gatsby): allow setting importSource on preset-react #29260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With React 17's new JSX transform feature, it is possible to pass a custom JSX factory besides React's default one. This is useful when working with libraries like Emotion 11: https://emotion.sh/docs/css-prop#babel-preset. In order to support this feature in `babel-preset-gatsby`, this PR adds an option called `reactImportSource` that is passed down to the underlying `@babel/preset-react` preset option `importSource`. Users of `babel-preset-gatsby` can then use this like so: ```json { "presets": [ [ "babel-preset-gatsby", { "reactRuntime": "automatic", "reactImportSource": "@emotion/react" } ] ] } ```
|
@vladar do I need to do anything to make "Cloud Tests" go green? |
7711836 to
6007072
Compare
ascorbic
approved these changes
Feb 25, 2021
|
Thanks for the PR @disintegrator! We want to get this in today so I made a few small changes, but wanted to make sure you got credit for the contribution as well. |
|
Fantastic, happy to see this go in! Thanks @laurieontech :) |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With React 17's new JSX transform feature, it is possible to pass a custom JSX factory besides React's default one. This is useful when working with libraries like Emotion 11: https://emotion.sh/docs/css-prop#babel-preset.
In order to support this feature in
babel-preset-gatsby, this PR adds an option calledreactImportSourcethat is passed down to the underlying@babel/preset-reactpreset optionimportSource.Users of
babel-preset-gatsbycan then use this like so:{ "presets": [ [ "babel-preset-gatsby", { "reactRuntime": "automatic", "reactImportSource": "@emotion/react" } ] ] }