Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(docs): Fix product slugs for building-an-ecommerce-site-with-shopify page #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2021
Merged

chore(docs): Fix product slugs for building-an-ecommerce-site-with-shopify page #29292

merged 2 commits into from
Feb 8, 2021

Conversation

deraru
Copy link
Contributor

@deraru deraru commented Feb 1, 2021

Description

Correct the gatsby-node.js configuration on building-an-ecommerce-site-with-shopify page.

In the document,

Each page gets assigned a URL in the format of /products/[product handle].

but the sample gatsby-node.js configuration on the page is

    createPage({
      path: `/product/${node.handle}`,

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 1, 2021
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 8, 2021
@LekoArts LekoArts changed the title chore(docs): Fix gatsby-node.js on building-an-ecommerce-site-with-shopify page chore(docs): Fix product slugs for building-an-ecommerce-site-with-shopify page Feb 8, 2021
LekoArts
LekoArts approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit d719644 into gatsbyjs:master Feb 8, 2021
@deraru
Copy link
Contributor Author

deraru commented Feb 8, 2021

Wow! I'm happy with my first contribution to Gatsby!

@deraru deraru deleted the docs/fix-gatsby-node-config branch February 8, 2021 10:22
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot @LekoArts
chore(docs): Fix product slugs for building-an-ecommerce-site-with-sh…
7caca3f 
…opify page (gatsbyjs#29292)

Co-authored-by: Lennart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LekoArts LekoArts LekoArts approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deraru @LekoArts