Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(gatsby-plugin-canonical-urls): Add plugin validation #29688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

feat(gatsby-plugin-canonical-urls): Add plugin validation #29688

merged 1 commit into from
Feb 22, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Feb 22, 2021 •
edited
Loading

Fix #28138 (comment)

With DEV_SSR, the plugin now errors if you don't set the required siteUrl option. It didn't actually work before but at least it didn't work silently :-D

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@wardpeet wardpeet merged commit 4d4a7ab into master Feb 22, 2021
@wardpeet wardpeet deleted the canonical-urls-options branch February 22, 2021 21:18
@wardpeet wardpeet added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 22, 2021
This was referenced Mar 11, 2021
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@wardpeet wardpeet wardpeet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleAMathews @wardpeet