Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(gatsby-source-contentful): Increase Contentful sync by up to 10x #30422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2021
Merged

feat(gatsby-source-contentful): Increase Contentful sync by up to 10x #30422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0b3f63
perf(contentful): increase default pageLimit to 1000 and implement ba…
axe312ger Mar 23, 2021
0922325
style: use String.includes instead of indexOf
axe312ger Mar 29, 2021
85ed360
docs: add comment about page-limit backoff logic
axe312ger Mar 29, 2021
4fc1237
fix(contentful): merge with master and improve network error detection
axe312ger Mar 29, 2021
8f8651f
revert some accidential changes to the tests
axe312ger Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert some accidential changes to the tests
  • Loading branch information
@axe312ger
axe312ger committed Mar 29, 2021
commit 8f8651f4713e657f9563c59bfdb2de6e10323cd6
4 changes: 2 additions & 2 deletions packages/gatsby-source-contentful/src/__tests__/fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ describe(`Displays troubleshooting tips and detailed plugin options on contentfu
it(`API 404 response handling`, async () => {
mockClient.getLocales.mockImplementation(() => {
const err = new Error(`error`)
err.status = 404
err.responseData = { status: 404 }
throw err
})

Expand Down Expand Up @@ -295,7 +295,7 @@ describe(`Displays troubleshooting tips and detailed plugin options on contentfu
it(`API authorization error handling`, async () => {
mockClient.getLocales.mockImplementation(() => {
const err = new Error(`error`)
err.status = 401
err.responseData = { status: 401 }
throw err
})

Expand Down
6 changes: 3 additions & 3 deletions packages/gatsby-source-contentful/src/fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ module.exports = async function contentfulFetch({
sourceMessage: `We couldn't make a secure connection to your contentful space. Please check if you have any self-signed SSL certificates installed.`,
},
})
} else if (e.status) {
if (e.status === 404) {
} else if (e.responseData) {
if (e.responseData.status === 404) {
// host and space used to generate url
details = `Endpoint not found. Check if ${chalk.yellow(
`host`
Expand All @@ -169,7 +169,7 @@ module.exports = async function contentfulFetch({
host: `Check if setting is correct`,
spaceId: `Check if setting is correct`,
}
} else if (e.status === 401) {
} else if (e.responseData.status === 401) {
// authorization error
details = `Authorization error. Check if ${chalk.yellow(
`accessToken`
Expand Down