SegmentSet.Add allow missing LastOffset #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraettinger
approved these changes
Jan 23, 2024
Contributor
jgraettinger
left a comment
There was a problem hiding this comment.
LGTM, but can we also remove this ?
Contributor
Author
I can update the comment, but my understanding is that the code to zero out the |
Allows adding a "covering" segment to a `SegmentSet`. Given an non-empty set, this permits adding a segment that completely covers a subset of existing segments and has `LastOffset: 0`. This is needed in order to reduce backup and primary hints into the same set, which is needed by `shards prune` in order to prune recovery logs conservatively.
bb3ede9 to
e650aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding a "covering" segment to a
SegmentSet. Given an non-empty set, this permits adding a segment that completely covers a subset of existing segments and hasLastOffset: 0. This is needed in order to reduce backup and primary hints into the same set, which is needed byshards prunein order to prune recovery logs conservatively.I realized that the other fix is truly not necessary, because the existing behavior of zeroing the final segment of each set of hints is retained, and serves the same purpose.
With this change, I'm able to successfully dry-run pruning all the shards in Estuary's production environment.
This change is