fix: restore auth on startup #18
Conversation
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request restores the intended behavior of triggering the authentication flow immediately when the server starts. This change ensures that users are proactively prompted to authenticate, if necessary, right after the plugin launches, thereby improving the initial user experience by preventing delays associated with on-demand authentication. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request restores eager authentication on server startup. The implementation is a single, clear line of code that achieves this goal. However, this change introduces a regression for users in headless or non-interactive environments by blocking server startup if user interaction is needed for authentication, preventing even non-authenticated tools from being used. I've added a comment with more details on this potential issue.
Restores the behavior where the authentication flow is triggered immediately upon server startup. This ensures that users are prompted to authenticate (if needed) as soon as the plugin is launched, rather than waiting for the first tool usage.