Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(js/plugin/compat-oai): Fix type overload shadowing bug for OpenAI models with specific suffixes#4263

Merged
ssbushi merged 3 commits into
genkit-ai:mainfrom
7hokerz:7hokerz/compat-oai-type-overload-shadowing
Jan 27, 2026
Merged

fix(js/plugin/compat-oai): Fix type overload shadowing bug for OpenAI models with specific suffixes#4263
ssbushi merged 3 commits into
genkit-ai:mainfrom
7hokerz:7hokerz/compat-oai-type-overload-shadowing

Conversation

@7hokerz

@7hokerz 7hokerz commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Description here... Help the reviewer by:

Checklist (if applicable):

@github-actions github-actions Bot added the js label Jan 25, 2026
@gemini-code-assist

gemini-code-assist Bot commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @7hokerz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical type shadowing bug within the OpenAI plugin's model definitions. By strategically reordering the model function overloads in the index.ts file, the change ensures that TypeScript correctly infers types for various OpenAI models, particularly those identified by gpt- or o prefixes. This prevents potential compilation errors and ensures the plugin functions as expected with diverse model identifiers.

Highlights

  • Type Overload Shadowing Fix: Resolved a bug where type overloads for OpenAI models, specifically those with gpt- or o suffixes, were being shadowed, leading to incorrect type inference.
  • Function Overload Reordering: The model function overloads in js/plugins/compat-oai/src/openai/index.ts were reordered to ensure the correct type signature is picked up by the TypeScript compiler, addressing the shadowing issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a type overload shadowing bug in the OpenAIPlugin type by reordering the model function overloads. The change correctly places more specific model type definitions (for image, TTS, and STT models) before the more general GPT model definition. This ensures that TypeScript's type resolution correctly identifies models with specific suffixes like -tts or -transcribe, preventing them from being incorrectly typed as generic GPT models. The fix is clean, effective, and improves the overall type safety of the plugin. The changes look good.

@7hokerz 7hokerz marked this pull request as draft January 25, 2026 13:39
@7hokerz 7hokerz force-pushed the 7hokerz/compat-oai-type-overload-shadowing branch from c091845 to d17b179 Compare January 25, 2026 13:46
@7hokerz 7hokerz marked this pull request as ready for review January 25, 2026 13:48
@xavidop

xavidop commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

good catch!

@pavelgj pavelgj requested a review from ssbushi January 26, 2026 21:00
ssbushi
ssbushi approved these changes Jan 27, 2026
View reviewed changes

@ssbushi ssbushi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ssbushi ssbushi merged commit 04b1bc0 into genkit-ai:main Jan 27, 2026
5 checks passed
@7hokerz 7hokerz deleted the 7hokerz/compat-oai-type-overload-shadowing branch January 28, 2026 10:12
MengqinShen pushed a commit that referenced this pull request Jan 29, 2026
@7hokerz @MengqinShen-GL
fix(js/plugin/compat-oai): Fix type overload shadowing bug for OpenAI…
4e61729 
… models with specific suffixes (#4263)
@yesudeep yesudeep mentioned this pull request Feb 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xavidop xavidop xavidop approved these changes

@ssbushi ssbushi ssbushi approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7hokerz @xavidop @ssbushi