fix(js/core): fix ValidationResponse type and cache ajv validators#5201
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the schema validation logic in js/core/src/schema.ts, including renaming the AJV validator cache and error mapping functions, and updating the ValidationResponse type for improved clarity. The validateSchema function was updated to better handle caching and return structures. Feedback highlights a potential TypeError when using boolean schemas as WeakMap keys, the need for safer handling of optional error messages in AJV, and the importance of maintaining safety checks when processing validation errors.
ssbushi
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description here... Help the reviewer by:
ValidationResponseinstead of using the previously unused type.ajvValidatorsin the validation process.ValidationResponseas the fixed return type forvalidateSchemaChecklist (if applicable):