Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement PluginProvider and awesome plugin support #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 3, 2017
Merged

Implement PluginProvider and awesome plugin support #150

merged 10 commits into from
Aug 3, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 16, 2017

We just need to create the PluginProvider and append the plugin to it.

Blocked by geocoder-php/Geocoder#742

This will fix #129 and fix #151

@Nyholm Nyholm added this to the Version 5.0.0 milestone Jul 16, 2017
@willdurand willdurand self-requested a review July 16, 2017 12:43
@willdurand
Copy link
Member

Ok now I see the usefulness of this plugin feature. I'm 👍

@Nyholm Nyholm changed the title First look how to add FakeIpPlugin Implement PluginProvider and awesome plugin support Aug 3, 2017
@Nyholm
Copy link
Member Author

Nyholm commented Aug 3, 2017

This PR is now ready for a final review

@Nyholm
Copy link
Member Author

Nyholm commented Aug 3, 2017

screen shot 2017-08-03 at 18 20 58

@Nyholm Nyholm merged commit df4b6e3 into master Aug 3, 2017
@Nyholm Nyholm deleted the fake-ip branch August 3, 2017 16:41
@willdurand
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayout the profiler page get a SecureIp with bazinga geocoder
2 participants