-
Notifications
You must be signed in to change notification settings - Fork 522
Release 5.0.0 not available in sub projects #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, would be also nice to have the 8.4 fixes released for geocoder-php/geoip2-provider 🙏 |
5.0.0 is released but it doesn't seem to have propagated to the subtree splits e.g geocoder-php/google-maps-provider still only has a 4.7.1 release. |
@jbelien are you able to see why we can't upgrade to 5.0.0 for the sub projects that are built off this repo? E.g https://packagist.org/packages/geocoder-php/google-maps-provider |
I'll have a look!
There might be a conflict with another library. I'll check 👍 |
There is no relation between the release number of a provider and the release number of the "main" package! |
Issue confirmed! $ composer require geocoder-php/google-maps-provider guzzlehttp/guzzle
...
Installing dependencies from lock file (including require-dev)
Package operations: 12 installs, 0 updates, 0 removals
- Downloading php-http/discovery (1.20.0)
- Downloading willdurand/geocoder (4.6.0)
- Downloading guzzlehttp/psr7 (2.7.1)
- Downloading symfony/deprecation-contracts (v3.5.1)
- Downloading guzzlehttp/promises (2.2.0)
- Downloading guzzlehttp/guzzle (7.9.3)
- Downloading geocoder-php/common-http (4.6.0)
- Downloading geocoder-php/google-maps-provider (4.7.1)
... We indeed forgot to create a new release for the providers. The I'll take care of it now! 👍 |
|
Should now be good for Seems to work indeed! Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
- Upgrading geocoder-php/common-http (4.6.0 => 4.7.0)
- Upgrading willdurand/geocoder (4.6.0 => 5.0.0) |
Amazing, thanks @jbelien! |
All "address providers" have been released. |
All providers have been released! |
@jbelien it still blocks to install willdurand/geocoder v5 for BazingaGeocoderBundle as it requires https://github.com/geocoder-php/plugin which did not get new release |
Sorry, I indeed forgot |
Thank you |
@jbelien just wanted to remind you :) |
✅ Done! https://github.com/geocoder-php/plugin/releases/tag/1.6.0 |
Thank you! |
I'm working on upgrading to PHP 8.4 and currently 4.7.1 has a lot of deprecations due to implicit nullables. All of these are fixed in HEAD and by the looks of the other changes, it's mostly PHPCS/vanity stuff. It would be great to get a new stable release for sites to upgrade to using PHP 8.4
geocoder-php/google-maps-provider@4.7.1...master
The text was updated successfully, but these errors were encountered: