Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release 5.0.0 not available in sub projects #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acbramley opened this issue Jan 23, 2025 · 18 comments
Closed

Release 5.0.0 not available in sub projects #1241

acbramley opened this issue Jan 23, 2025 · 18 comments
Labels

Comments

@acbramley
Copy link

I'm working on upgrading to PHP 8.4 and currently 4.7.1 has a lot of deprecations due to implicit nullables. All of these are fixed in HEAD and by the looks of the other changes, it's mostly PHPCS/vanity stuff. It would be great to get a new stable release for sites to upgrade to using PHP 8.4

geocoder-php/google-maps-provider@4.7.1...master

@steffans
Copy link

Yes, would be also nice to have the 8.4 fixes released for geocoder-php/geoip2-provider 🙏

@acbramley
Copy link
Author

acbramley commented Mar 4, 2025

5.0.0 is released but it doesn't seem to have propagated to the subtree splits e.g geocoder-php/google-maps-provider still only has a 4.7.1 release.

@acbramley acbramley changed the title Release 4.8.0? Release 5.0.0 not available in sub projects Apr 15, 2025
@acbramley
Copy link
Author

@jbelien are you able to see why we can't upgrade to 5.0.0 for the sub projects that are built off this repo? E.g https://packagist.org/packages/geocoder-php/google-maps-provider

@jbelien
Copy link
Member

jbelien commented Apr 15, 2025

I'll have a look!

composer.json seems to allow version 5:

"willdurand/geocoder": "^4.0|^5.0"

There might be a conflict with another library. I'll check 👍

@jbelien
Copy link
Member

jbelien commented Apr 15, 2025

5.0.0 is released but it doesn't seem to have propagated to the subtree splits e.g geocoder-php/google-maps-provider still only has a 4.7.1 release.

There is no relation between the release number of a provider and the release number of the "main" package!
Version 4.7.1 of Google Maps provider does support version 5.0.0 of our "main" package (see previous comment).

@norkunas
Copy link
Member

norkunas commented Apr 15, 2025

@jbelien no, it does not: https://github.com/geocoder-php/google-maps-provider/blob/4.7.1/composer.json

@jbelien
Copy link
Member

jbelien commented Apr 15, 2025

Issue confirmed!

$ composer require geocoder-php/google-maps-provider guzzlehttp/guzzle

...
Installing dependencies from lock file (including require-dev)
Package operations: 12 installs, 0 updates, 0 removals
  - Downloading php-http/discovery (1.20.0)
  - Downloading willdurand/geocoder (4.6.0)
  - Downloading guzzlehttp/psr7 (2.7.1)
  - Downloading symfony/deprecation-contracts (v3.5.1)
  - Downloading guzzlehttp/promises (2.2.0)
  - Downloading guzzlehttp/guzzle (7.9.3)
  - Downloading geocoder-php/common-http (4.6.0)
  - Downloading geocoder-php/google-maps-provider (4.7.1)
...

We indeed forgot to create a new release for the providers. The composer.json file is up-to-date but no release was created for most of the providers.
And we need to start with geocoder-php/common-http.

I'll take care of it now! 👍

@jbelien jbelien added the bug label Apr 15, 2025
@jbelien
Copy link
Member

jbelien commented Apr 15, 2025

  • Common HTTP: geocoder-php/common-http
  • Cache: geocoder-php/cache-provider
  • Chain: geocoder-php/chain-provider
  • AlgoliaPlaces: geocoder-php/algolia-places-provider
  • ArcGISOnline: geocoder-php/arcgis-online-provider
  • AzureMaps: geocoder-php/azure-maps-provider
  • BingMaps: geocoder-php/bing-maps-provider
  • FreeGeoIp: geocoder-php/free-geoip-provider
  • GeoIP2: geocoder-php/geoip2-provider
  • GeoPlugin: geocoder-php/geo-plugin-provider
  • GeocodeEarth: geocoder-php/geocode-earth-provider
  • Geonames: geocoder-php/geonames-provider
  • GoogleMaps: geocoder-php/google-maps-provider
  • GoogleMapsPlaces: geocoder-php/google-maps-places-provider
  • GraphHopper: geocoder-php/graphhopper-provider
  • Here: geocoder-php/here-provider
  • HostIp: geocoder-php/host-ip-provider
  • IP2Location: geocoder-php/ip2location-provider
  • IP2LocationBinary: geocoder-php/ip2location-binary-provider
  • IpInfo: geocoder-php/ip-info-provider
  • IpInfoDb: geocoder-php/ip-info-db-provider
  • Ipstack: geocoder-php/ipstack-provider
  • LocationIQ: geocoder-php/locationiq-provider
  • MapQuest: geocoder-php/mapquest-provider
  • MapTiler: geocoder-php/maptiler-provider
  • Mapbox: geocoder-php/mapbox-provider
  • MaxMind: geocoder-php/maxmind-provider
  • MaxMindBinary: geocoder-php/maxmind-binary-provider
  • Nominatim: geocoder-php/nominatim-provider
  • OpenCage: geocoder-php/open-cage-provider
  • OpenRouteService: geocoder-php/openrouteservice-provider
  • Pelias: geocoder-php/pelias-provider
  • Photon: geocoder-php/photon-provider
  • PickPoint: geocoder-php/pickpoint-provider
  • TomTom: geocoder-php/tomtom-provider
  • Yandex: geocoder-php/yandex-provider

@jbelien
Copy link
Member

jbelien commented Apr 15, 2025

Should now be good for geocoder-php/google-maps-provider! 👍
I'll take care of all providers in the next few days.


Seems to work indeed!

Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
  - Upgrading geocoder-php/common-http (4.6.0 => 4.7.0)
  - Upgrading willdurand/geocoder (4.6.0 => 5.0.0)

@acbramley
Copy link
Author

❯ composer require geocoder-php/google-maps-provider:^4.8 -W
./composer.json has been updated
Running composer update geocoder-php/google-maps-provider --with-all-dependencies
Gathering patches from patch file.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading geocoder-php/common-http (4.6.0 => 4.7.0)
  - Upgrading geocoder-php/google-maps-provider (4.7.1 => 4.8.0)
  - Upgrading willdurand/geocoder (4.6.0 => 5.0.0)

Amazing, thanks @jbelien!

@jbelien
Copy link
Member

jbelien commented Apr 16, 2025

All "address providers" have been released.
I'll take care of all "IP providers" a bit later.

@jbelien
Copy link
Member

jbelien commented Apr 16, 2025

All providers have been released!

@norkunas
Copy link
Member

@jbelien it still blocks to install willdurand/geocoder v5 for BazingaGeocoderBundle as it requires https://github.com/geocoder-php/plugin which did not get new release

@jbelien jbelien reopened this May 1, 2025
@jbelien
Copy link
Member

jbelien commented May 1, 2025

Sorry, I indeed forgot geocoder-php/plugin.
I'll try to take care of it in the next few days.

@norkunas
Copy link
Member

norkunas commented May 1, 2025

Thank you

@norkunas
Copy link
Member

@jbelien just wanted to remind you :)

@jbelien
Copy link
Member

jbelien commented May 17, 2025

@jbelien it still blocks to install willdurand/geocoder v5 for BazingaGeocoderBundle as it requires https://github.com/geocoder-php/plugin which did not get new release

✅ Done! https://github.com/geocoder-php/plugin/releases/tag/1.6.0

@jbelien jbelien closed this as completed May 17, 2025
@norkunas
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants