Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add PHPStan in CI #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 16, 2023
Merged

Add PHPStan in CI #1193

merged 27 commits into from
Jul 16, 2023

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented Jul 9, 2023

Implement PHPStan everywhere.
Limited to level 5 at the moment because level 6 is related to missing typehints and has 820 errors ; it will be tackled in a next PR.

@jbelien jbelien self-assigned this Jul 9, 2023
@jbelien jbelien mentioned this pull request Jul 9, 2023
@jbelien jbelien marked this pull request as ready for review July 9, 2023 16:07
@jbelien jbelien requested review from Nyholm and norkunas July 9, 2023 16:07
@jbelien
Copy link
Member Author

jbelien commented Jul 9, 2023

Also updated geocoder-php/provider-integration-tests ; see geocoder-php/provider-integration-tests#19

@jbelien jbelien merged commit c83b9da into master Jul 16, 2023
@jbelien jbelien deleted the phpstan branch July 16, 2023 14:36
@jbelien
Copy link
Member Author

jbelien commented Jul 16, 2023

Thanks for the help and review @norkunas 👍

@jbelien
Copy link
Member Author

jbelien commented Jul 16, 2023

I've started to work on Level 6 in #1194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants