Add PickPoint provider. #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c3e98b to
efc9ab0
Compare
Nyholm
approved these changes
Jun 28, 2017
src/Provider/PickPoint/PickPoint.php
Outdated
| /** | ||
| * @author Vladimir Kalinkin <[email protected]> | ||
| */ | ||
| final class PickPoint extends AbstractHttpProvider implements LocaleAwareGeocoder, Provider |
There was a problem hiding this comment.
Remove LocaleAwareGeocoder. See #720
| class IntegrationTest extends ProviderIntegrationTest | ||
| { | ||
| protected $testAddress = true; | ||
| protected $testReverse = true; |
There was a problem hiding this comment.
This should be the other way around. Look in ProviderIntegrationTest. All tests are enabled by default, you should write ie $testIpv4 = false
There was a problem hiding this comment.
@Nyholm, thank you for the review, I will fix it!
Fixed style. Apply review notes.
efc9ab0 to
e0167b6
Compare
|
@Nyholm, requested changes are applied. |
|
Great work |
|
Oh, i forgot, you should update the table on the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PickPoint geocoder, which is commercial version of Nominatim hosted at https://pickpoint.io.