Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add place_id to GoogleAddress #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2017
Merged

Add place_id to GoogleAddress #750

merged 2 commits into from
Jul 25, 2017

Conversation

arubacao
Copy link
Contributor

For #749

Cheers,
Chris

@willdurand willdurand requested a review from Nyholm July 24, 2017 23:19
Nyholm
Nyholm approved these changes Jul 25, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you.

src/Provider/GoogleMaps/Model/GoogleAddress.php
@@ -22,6 +22,11 @@
/**
* @var string|null
*/
private $id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment explaining that this is the "place id"

src/Provider/GoogleMaps/Model/GoogleAddress.php

/**
* @see https://developers.google.com/places/place-id
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. This is great.

@Nyholm Nyholm merged commit 5bbf3f7 into geocoder-php:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arubacao @Nyholm