Remove usage of deprecated class HttplugFactory #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4091f59 to
e6ad922
Compare
jbelien
previously requested changes
Aug 6, 2023
There was a problem hiding this comment.
I'm a bit confused:
- Why do we need the addition of
php-http/curl-clientlibrary ? - Why not use
Nyholm\Psr7\Factory\Psr17Factoryas suggested by the library (see https://github.com/Nyholm/psr7/blob/master/src/Factory/HttplugFactory.php#L18)
@Nyholm Your input is very much welcome here. 😄
Because it's used here:
Because a factory is meant to provide interop, which is something we don't care about here. Since we depend on nyholm/psr7, we know how a stream should be instantiated. |
Nyholm
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.