Feat: Add Spark connector #3437
Conversation
…ent, list transactions)
other connectors were broken cause of mnemonic conditionals directly included in state
feat: mnemonic generation for spark connector
|
@pavanjoshi914 I think we should fix this before merging. The link to setup the keys is also broken because it shows steps to create a new master key. 
I think it would be simpler to derive the nostr key too when generating the master key and extract the code so the same things happen when we generate a master key for Spark as what happens if you generate a master key normally. CC @reneaaron @bumi |
| data: nostrPrivateKey, | ||
| }; | ||
| nostrPrivateKey = mnemonic.deriveNostrPrivateKeyHex(); | ||
| } else if (message.args?.mnemonic) { |
There was a problem hiding this comment.
I'm just wondering if this is the best approach since we add more complexity to these functions to both handle accounts and non-accounts.
But I can't see any other way except actually creating the account before we validate it 🤔
There was a problem hiding this comment.
creating account before validating will go totally opposite to the existing flows that we have for other connectors. instead its better to handle this at script level
it just generates key in two way. either getting mnemonic from account id or if its passed explicitly. i guess this is more better to do somehow
|
@bumi @reneaaron we introduce something new here with the mnemonic generation before the account creation, and it creates a bit of complexity in the code. Not sure if this is OK for now or there is a better way we could do it? |
spark connector