fix(editor): zoom/pan the whole timeline pane on scroll, not just the lanes (cherry-pick for 1.10.0-rc.2) - #477
Merged
EtienneLescot merged 2 commits intoAug 22, 2026
Conversation
… lanes The wheel listener lived on .tlTracks alone, so Ctrl/Shift+scrolling over the ruler, the hint labels, or the nav bar did nothing — only scrolling over the lanes zoomed or panned.
CodeRabbit flagged that the panel-wide wheel fix only had regression coverage for Ctrl+wheel zoom from the ruler, not Shift+wheel pan.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #467 onto
release/v1.10.0for the 1.10.0-rc.2 cut.Summary
.tlTracksalone, so scrolling over the ruler, the hint labels, or the nav/minimap bar silently did nothing — only the lanes responded..tlcontainer) while keeping the geometry math anchored to the tracks element.Test plan
release/v1.10.0, no conflictsnpx vitest --runon the two affected test files — 16 passednpx biome checkon changed files — cleannpx tsc --noEmit— clean🤖 Generated with Claude Code