Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ref: Delete obsolete docs#135

Closed
BYK wants to merge 2 commits into
masterfrom
byk/ref/delete-obsolete-docs
Closed

ref: Delete obsolete docs#135
BYK wants to merge 2 commits into
masterfrom
byk/ref/delete-obsolete-docs

Conversation

@BYK

@BYK BYK commented Nov 17, 2020

Copy link
Copy Markdown
Member

The docs directory here was a stub and was not used. This was leading to confusion and also triggering Dependapot alerts due to stale dependency definitions inside. This PR removes the folder in the hopes of proper docs in the future.

The docs directory here was a stub and was not used. This was leading to confusion and also triggering Dependapot alerts due to stale dependency definitions inside. This PR removes the folder in the hopes of proper docs in the future.
@BYK BYK requested review from HazAT, jan-auer and tonyo November 17, 2020 08:29
@tonyo

tonyo commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

The docs directory is used to dogfood gh-pages target.
What confusion are we talking about here?

@BYK

BYK commented Nov 17, 2020

Copy link
Copy Markdown
Member Author

The actual docs live inside the README file and this directory seems unmaintained and empty of useful content.

I'm okay abandoning this PR but then we'd better make this intent more visible and update those vulnerable dependencies to stop getting dependabot alerts.

@tonyo

tonyo commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

The docs are responsible for rendering this page: https://getsentry.github.io/craft/
I'm ok with adding the docs directory to ignore list of dependabot.

@BYK BYK closed this Nov 17, 2020
@BYK BYK deleted the byk/ref/delete-obsolete-docs branch November 17, 2020 09:51
BYK added a commit that referenced this pull request Mar 27, 2026
## Summary

- Resolves Dependabot alert #142 (CVE-2026-33750): zero-step brace
sequence `{1..2..0}` causes infinite loop and ~1.9 GB memory exhaustion
in `brace-expansion` < 5.0.5
- Lockfile-only update β€” `[email protected]` accepts
`brace-expansion@^5.0.2`, so 5.0.5 is in range with no `package.json`
changes needed
- The remaining 5 Dependabot alerts (#141, #138, #137, #135, #133) are
already fixed; no security advisories exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants