Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(publish): Fix error when special target 'all' is used #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 2 commits into from
Dec 1, 2020
Merged

fix(publish): Fix error when special target 'all' is used #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef4443
fix(publish): Fix error when special target 'all' is used
BYK Dec 1, 2020
7d2dda8
Add PR number to CHANGELOG
BYK Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.13.4

- fix(publish): Fix error when special target 'all' is used (#142)

## 0.13.3

- fix(publish): Only allow valid target ids for -t (#137)
Expand Down
4 changes: 2 additions & 2 deletions src/commands/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,14 +470,14 @@ export async function publishMain(argv: PublishOptions): Promise<any> {

let targetConfigList = config.targets || [];

if (targetList.has(SpecialTarget.All)) {
if (!targetList.has(SpecialTarget.All)) {
targetConfigList = targetConfigList.filter(targetConf =>
targetList.has(getTargetId(targetConf))
);
}

if (!targetList.has(SpecialTarget.None)) {
if (!targetConfigList.length) {
if (targetConfigList.length === 0) {
logger.warn('No valid targets detected! Exiting.');
return undefined;
}
Expand Down