fix: hide the Objective-C ARC compile options in the interface library #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch, @mujacica, I forgot that the Native SDK PR still pointed to a commit on a PR in the crashpad repo. I need to merge this first and then update the submodule in the top-level. Can you approve this? |
jpnurmi
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised here: getsentry/sentry-native#1374
The Objective-C ARC compile options were incorrectly specified as
PUBLICand thus propagate indiscriminately into any parent target linkage. We can move them to thecrashpad_interfacetarget, which is only linked privately into any other targets of thecrashpadbuild and thus will never escape thecrashpadproject.