This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Handle streaming requests. - #516
Open
jmcarp wants to merge 1 commit into
Open
Conversation
In Tornado RequestHandler classes decorated with the stream_request_body decorator, the request body may be a Future instance rather than a string, which breaks currently breaks JSON serialization. This patch uses a modified JSON encoder for the Tornado module to handle this case and adds a test to prevent regressions.
Contributor
|
I have no idea about how tornado works. Would be happy to have someone review this |
There was a problem hiding this comment.
Perhaps you could do something slightly more explicit about Futures rather than just None.
if future.resolved():
return yield from future
else:
return future.__repr__()Other than that 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Tornado RequestHandler classes decorated with the stream_request_body
decorator, the request body may be a Future instance rather than a
string, which breaks currently breaks JSON serialization. This patch
uses a modified JSON encoder for the Tornado module to handle this case
and adds a test to prevent regressions.