Only register MauiSessionReplayMaskControlsOfTypeBinder when relevant #4445
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@Flash0ver it's lucky I took another look at this on the back of our chat yesterday. I had things completely backwards. See updated description in this PR and updated code. It's maybe worth considering whether we want to offer the |
| { | ||
| services.AddSingleton<IMauiElementEventBinder, MauiCustomSessionReplayMaskBinder>(); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Is that untrue because
- the
BindablePropertydoes set the tags for native (""sentry-mask""and"sentry-unmask") already - where the
IMauiElementEventBindermust now do the same for all configuredMaskedControls/UnmaskedControls
?
(just clarifying if I'm understanding it)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Resolves #4439:
Summary
In applications with complex user interfaces consisting of hundreds of controls on any individual page, the overhead of adding and removing events hooks to all of the
VisualElement.Loadedevents can cause significant performance delays.We use this event hook to set the Masking behaviour for visual controls of or descending from a particular type (controlled via
NativeSentryReplayOptions.MaskControlsOfType<T>()andNativeSentryReplayOptions.UnmaskControlsOfType<T>()).This PR:
MaskControlsOfTypeorUnmaskControlsOfTypeoptions are used