Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Aug 29, 2025

Bumps sentry-cocoa from 8.46.0 (Mar 1, 2025) to 8.53.2 (Jul 9, 2025):

Tested locally with:

  • Sentry.Samples.Ios on iossimulator-arm64
  • Sentry.Samples.Maui on iossimulator-arm64
  • pwsh scripts/device-test.ps1 ios -Run

See also:

Copy link

linear bot commented Aug 29, 2025

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Aug 29, 2025

Note: 8.53.2 is the last release before SentrySDK was converted to Swift in 8.54.0, which requires more work and is best addressed separately.

@jpnurmi jpnurmi marked this pull request as draft August 29, 2025 14:19
@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Aug 29, 2025

  1. First, iOS device tests + retry failed in the CI:

    info: Starting test run for io.sentry.dotnet.maui.device.testapp..
    info: Application finished the test run successfully with some failed tests
    info: Tests run: 2208 Passed: 2176 Inconclusive: 0 Failed: 1 Ignored: 31
    

    https://github.com/getsentry/sentry-dotnet/actions/runs/17323472305/job/49181841490?pr=4483

  2. I couldn't reproduce the failure locally, so I tried enabling verbose debug output for xharness to be able to see what goes wrong in the CI, but then the tests passed:

    info: Starting test run for io.sentry.dotnet.maui.device.testapp..
    dbug: [...]
    info: Application finished the test run successfully
    info: Tests run: 2208 Passed: 2177 Inconclusive: 0 Failed: 0 Ignored: 31
    

    https://github.com/getsentry/sentry-dotnet/actions/runs/17326219583/job/49190894046?pr=4483

  3. After reverting verbose debug output, the device tests still pass:
    https://github.com/getsentry/sentry-dotnet/actions/runs/17326894824/job/49193157045?pr=4483

Looks like the failure was not related to the Cocoa SDK upgrade, after all.

@jpnurmi jpnurmi marked this pull request as ready for review August 29, 2025 15:09
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamescrosswell jamescrosswell merged commit 42216b2 into main Aug 31, 2025
34 checks passed
@jamescrosswell jamescrosswell deleted the chore/sentry-cocoa-8.53.2 branch August 31, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants