Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: upload linked PDB for Mac Catalyst #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2025
Merged

fix: upload linked PDB for Mac Catalyst #4503

merged 3 commits into from
Sep 11, 2025

Conversation

jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Sep 9, 2025 •
edited
Loading

Debug files

Notice the linked .PDB is different:

$ dotnet build -c Release -f net9.0-maccatalyst -r maccatalyst-arm64 -v:detailed EmpowerPlant.csproj
[...]
$ find . -name "EmpowerPlant.pdb" \
  -exec sha256 {} \; \
  -exec sh -c 'sentry-cli debug-files check "$1" | grep "Debug ID:"' _ {} \;
SHA256 (./obj/Release/net9.0-maccatalyst/maccatalyst-arm64/EmpowerPlant.pdb) = 808cd311d68980163937ac7cbf3ff95feeae81548fce41a22d4400acaa246c86
    > Debug ID: 321a8892-9045-515a-afed-fee16c70ae58-fb0e5afa
SHA256 (./obj/Release/net9.0-maccatalyst/maccatalyst-arm64/linked/EmpowerPlant.pdb) = fe9da3d5f0e213335e0abc10118b0dccbee5b2fa072e3bb596c3dc39351d04cc
    > Debug ID: 0c9408e1-5ffe-b8a0-1ce1-17268aaab993-14c33dd9 # <=== !!!
SHA256 (./bin/Release/net9.0-maccatalyst/maccatalyst-arm64/EmpowerPlant.pdb) = 808cd311d68980163937ac7cbf3ff95feeae81548fce41a22d4400acaa246c86
    > Debug ID: 321a8892-9045-515a-afed-fee16c70ae58-fb0e5afa

Before

$ dotnet build -c Release -f net9.0-maccatalyst -v:detailed
...
    Preparing upload to Sentry for project 'EmpowerPlant' (Release/net9.0-maccatalyst): collecting debug symbols from bin/Release/net9.0-maccatalyst/maccatalyst-arm64/
    > Found 63 debug information files (1 with embedded sources)

After

$ dotnet build -c Release -f net9.0-maccatalyst -v:detailed
...
    Preparing upload to Sentry for project 'EmpowerPlant' (Release/net9.0-maccatalyst): collecting debug symbols from bin/Release/net9.0-maccatalyst/maccatalyst-arm64/ obj/Release/net9.0-maccatalyst/maccatalyst-arm64/linked/EmpowerPlant.pdb
    > Found 64 debug information files (2 with embedded sources)

Fixes: #4196

@jpnurmi jpnurmi marked this pull request as ready for review September 9, 2025 13:58
jamescrosswell
jamescrosswell approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @jpnurmi !

I just kicked off a 5.15.0 release so about the only thing to watch is the changelog, which always gets messed up when we make a release... when the release gets merged back into main, this is probably going to show in the release notes for 5.15.0.

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.38%. Comparing base (64de9b6) to head (3888939).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4503   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         479      479           
  Lines       17506    17506           
  Branches     3479     3479           
=======================================
+ Hits        12846    12847    +1     
+ Misses       3780     3779    -1     
  Partials      880      880

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jamescrosswell
jamescrosswell approved these changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jamescrosswell jamescrosswell merged commit b2b8d49 into main Sep 11, 2025
33 checks passed
@jamescrosswell jamescrosswell deleted the fix/mac-catalyst-pdb branch September 11, 2025 09:18
This was referenced Sep 11, 2025
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Open
@jpnurmi jpnurmi mentioned this pull request Sep 15, 2025
Draft
This was referenced Sep 15, 2025
Open
Open
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescrosswell jamescrosswell jamescrosswell approved these changes

@Flash0ver Flash0ver Awaiting requested review from Flash0ver Flash0ver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mac Catalyst exceptions not symbolicated
2 participants
@jpnurmi @jamescrosswell