Thanks to visit codestin.com
Credit goes to github.com

Skip to content

The javadoc of Sentry.flush says it's not implemented, despite it being implemented #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
craftamap opened this issue Mar 31, 2025 · 2 comments · Fixed by #4305
Closed

The javadoc of Sentry.flush says it's not implemented, despite it being implemented #4304

craftamap opened this issue Mar 31, 2025 · 2 comments · Fixed by #4305
Labels
Platform: Java

Comments

@craftamap
Copy link

Integration

sentry

Java Version

21

Version

8.5.0

Steps to Reproduce

  1. Go to

    sentry-java/sentry/src/main/java/io/sentry/Sentry.java

    Line 1033 in a1ad6ae

    * Flushes events queued up to the current Scopes. Not implemented yet.

Expected Result

No no-op comment.

This tripped me up when using the method, as I was confused if this even does something. Looking into the implementation with a debugger revealed that it does end up flushing the entities (In io.sentry.transport.QueuedThreadPoolExecutor#waitTillIdle).

I guess this is dependent on the Transport implementation chosen.

Actual Result

N/A
@github-project-automation github-project-automation bot moved this to Needs Discussion in [DEPRECATED] Mobile SDKs Mar 31, 2025
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 31, 2025
@philprime
Copy link

Hi @craftamap, thanks for bringing this up.

@romtsn @markushi can you give some insights here if this method is always not implemented or depending on configuration?

@adinauer
Copy link
Member

Thanks for opening this issue. Will send a PR to remove the part of the comment.

@adinauer adinauer mentioned this issue Mar 31, 2025
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in [DEPRECATED] Mobile SDKs Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Java
Projects
GitHub Issues with 👀 3
Archived in project
[DEPRECATED] Mobile SDKs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "not yet implemented" from flush comments getsentry/sentry-java
3 participants
@adinauer @craftamap @philprime