Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove "not yet implemented" from flush comments #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

Remove "not yet implemented" from flush comments #4305

merged 3 commits into from
Apr 1, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Sentry.flush as well as other flush methods had a comment saying "Not yet implemented" which is no longer true.

💡 Motivation and Context

Fixes #4304

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer requested a review from lcian as a code owner March 31, 2025 10:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.11 ms 490.49 ms 58.38 ms
Size 1.58 MiB 2.22 MiB 655.16 KiB

Previous results on branch: fix/flush-comment-noop

Startup times

Revision Plain With Sentry Diff
30f5b61 438.10 ms 500.38 ms 62.28 ms

App size

Revision Plain With Sentry Diff
30f5b61 1.58 MiB 2.22 MiB 655.17 KiB

@adinauer adinauer merged commit 708d339 into main Apr 1, 2025
34 checks passed
@adinauer adinauer deleted the fix/flush-comment-noop branch April 1, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The javadoc of Sentry.flush says it's not implemented, despite it being implemented
2 participants
@adinauer @romtsn