Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(sdk-init): Do not override user-defined SentryOptions #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

fix(sdk-init): Do not override user-defined SentryOptions #4262

merged 4 commits into from
Mar 19, 2025

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Mar 17, 2025

📜 Description

  • Check for NoOpInstance before setting the defaults

💡 Motivation and Context

Closes #2565

💚 How did you test it?

unit tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 433.30 ms 492.67 ms 59.37 ms
Size 1.58 MiB 2.22 MiB 653.07 KiB

Previous results on branch: rz/fix/ignored-options

Startup times

Revision Plain With Sentry Diff
0e342d8 460.10 ms 473.59 ms 13.49 ms
927ac33 406.56 ms 456.48 ms 49.92 ms

App size

Revision Plain With Sentry Diff
0e342d8 1.58 MiB 2.21 MiB 646.80 KiB
927ac33 1.58 MiB 2.22 MiB 653.06 KiB

markushi
markushi approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn enabled auto-merge (squash) March 19, 2025 12:38
@romtsn romtsn force-pushed the rz/fix/ignored-options branch from d0bdfe9 to 24dc2ac Compare March 19, 2025 16:47
@romtsn romtsn merged commit b5b9f8b into main Mar 19, 2025
33 checks passed
@romtsn romtsn deleted the rz/fix/ignored-options branch March 19, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setTransportGate has no effect
2 participants
@romtsn @markushi