Add new User Feedback API #4286
Conversation
Added Scopes.captureFeedback API Changed the MainActivity sample app to use the new API
|
Performance metrics 🚀
|
captureFeedback does not update scope lastEventId anymore
added SentryOptions.beforeSendFeedback implemented SentryClient.captureFeedback
# Conflicts: # CHANGELOG.md # sentry/api/sentry.api # sentry/src/main/java/io/sentry/SentryClient.java
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
1 similar comment
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
| public void setMessage(final @NotNull String message) { | ||
| this.message = message; | ||
| } |
There was a problem hiding this comment.
according to develop there's a limit of 4096 characters for the message, is this something we wanna let relay handle?
There was a problem hiding this comment.
i was thinking so, in case the limit changes in the future
It's the same with the old user reports, where there is a 4096 limit, but the SDK doesn't check for it.
Do you think it makes more sense to check in the SDK, too?
There was a problem hiding this comment.
imo relay should just handle it so it's fine
iirc we're generally now relying on relay to truncate things vs doing it client side
but in this case I'm not sure if relay will reject the feedback or truncate the body
📜 Description
Added new User Feedback APIs (Sentry.captureFeedback)
Still need to add tests
💡 Motivation and Context
Implements #3614
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps