Continuous Profiling - stop when app goes in background #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added platform "android" in ProfileChunk envelope items
…dContinuousProfiler Added "delayed" stop of profiler, which stops the profiler after the current chunk is finished Added default span data (profiler id, thread name and thread id) to transaction root span
|
7 tasks
markushi
requested changes
Apr 4, 2025
| @@ -122,6 +122,7 @@ public void run() { | |||
| scopes.endSession(); | |||
| } | |||
| scopes.getOptions().getReplayController().stop(); | |||
| scopes.getOptions().getContinuousProfiler().stopAllProfiles(); | |||
There was a problem hiding this comment.
This means the profiler will continue to run for 30s in the background before stopping, is this what we want?
There was a problem hiding this comment.
yes, and actually stops after 30s and the last chunk is finished
There was a problem hiding this comment.
Alright, to be honest I still wouldn't do this. Once the app is in background, any executed code can easily produce a background ANR.
There was a problem hiding this comment.
true, but if we don't, the profiler could continue to run indefinitely, right?
sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java
Outdated
Show resolved
Hide resolved
markushi
approved these changes
Apr 7, 2025
…-background # Conflicts: # CHANGELOG.md # sentry-android-core/src/main/java/io/sentry/android/core/AndroidContinuousProfiler.java # sentry-android-core/src/test/java/io/sentry/android/core/AndroidContinuousProfilerTest.kt
added AndroidContinuousProfiler.close param isTerminating
markushi
approved these changes
Apr 7, 2025
Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
app going in the background now stops the continuous profiler
💡 Motivation and Context
Going to the background (after the session timer) should stop the profiler, as decided in the doc. Note that it shouldn't restart when it goes to the foreground again
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps