Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Determine recording size based on active window #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

markushi
Copy link
Member

@markushi markushi commented Apr 24, 2025

📜 Description

Instead of relying on the window metrics, we now determine the size based on the top level Window View, once determined the RecordingConfig is created and actual recording is started.

I couldn't re-use the onConfigurationChanged hook, as it removes all rootViews. But in case of Dialogs, the root views are stacked and as soon as the dialog is popped, no more root view would be available.

I tried to apply my changes with minimal impact to the existing structure, happy to restructure it in a better way too, I simply wasn't sure how hybrids consume the existing APIs.

💡 Motivation and Context

Fixes #3574
Fixes #4358

💚 How did you test it?

Manual testing, see e.g. https://sentry-sdks.sentry.io/replays/f278df82391b4b30a7b1cb8b99b15578/?project=5428559&query=&referrer=%2Freplays%2F&statsPeriod=10m&yAxis=count%28%29

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.46 ms 433.92 ms 35.46 ms
Size 1.58 MiB 2.08 MiB 507.51 KiB

Previous results on branch: markushi/fix/stretched-dialogs-sr

Startup times

Revision Plain With Sentry Diff
168b278 427.60 ms 465.36 ms 37.76 ms

App size

Revision Plain With Sentry Diff
168b278 1.58 MiB 2.08 MiB 507.51 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in fun onConfigurationChanged() [SR] Dialog windows are stretched
1 participant