Avoid ExecutorService for DefaultCompositePerformanceCollector timeout#4841
Merged
stefanosiano merged 10 commits intomainfrom Oct 29, 2025
Merged
Conversation
…ollection for timeout on data collection rather than a scheduled background job
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| 96449e8 | 361.30 ms | 423.39 ms | 62.09 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| b3d8889 | 371.84 ms | 447.49 ms | 75.65 ms |
| 27d7cf8 | 369.82 ms | 422.62 ms | 52.80 ms |
| d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 96449e8 | 1.58 MiB | 2.11 MiB | 539.35 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
Previous results on branch: stefanosiano/fix/performance-data-collection-timeout
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 77933c2 | 312.19 ms | 353.16 ms | 40.97 ms |
| f8c8b31 | 335.17 ms | 436.20 ms | 101.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 77933c2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| f8c8b31 | 1.58 MiB | 2.12 MiB | 551.20 KiB |
romtsn
reviewed
Oct 28, 2025
sentry/src/main/java/io/sentry/DefaultCompositePerformanceCollector.java
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Oct 28, 2025
romtsn
reviewed
Oct 28, 2025
Member
romtsn
left a comment
There was a problem hiding this comment.
there's one comment I'm not sure about
…-timeout # Conflicts: # CHANGELOG.md
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…a-collection-timeout' into stefanosiano/fix/performance-data-collection-timeout
Contributor
Author
|
@romtsn last check and approval? 😄 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
DefaultCompositePerformanceCollector now stops the performance data collection for timeout on data collection rather than a scheduled background job
💡 Motivation and Context
Every time a transaction run, the SDK starts collecting performance data (cpu and ram usage) and schedules a timeout job after 30 seconds to stop this data collection.
Since v
8.19.0we have a limit on the queue of our background executor of 271 scheduled jobs. Any other scheduled job is ignored.This means that if a transaction runs forever and the background thread queue is full, its performance data will be collected forever, leading eventually to an OOM.
More in this doc
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps