Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ref(feedback): Let CropCorner inherit the existing h prop #12814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

ref(feedback): Let CropCorner inherit the existing h prop #12814

merged 1 commit into from
Jul 9, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jul 9, 2024 •
edited
Loading

I noticed this after #12784, but the <CropCorner> wasn't inside the ScreenshotEditorFactory() function. So of course it wasn't getting access to the h ref that is passed in. That variable is what the <div> gets transpiled into -> it becomes h.createElement('div').

So what i'm doing is moving CropCorner into a CropCornerFactory so we can pass h in and hopefully not have the extra import .. from 'preact'; in the 2nd bundle.

Related to #12535

@ryan953 ryan953 requested a review from a team as a code owner July 9, 2024 00:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

size-limit report 📦

Path Size
@sentry/browser 22.28 KB (0%)
@sentry/browser (incl. Tracing) 33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.87 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.73 KB (+0.03% 🔺)
@sentry/browser (incl. metrics) 26.57 KB (0%)
@sentry/browser (incl. Feedback) 38.95 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) 26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.52 KB (0%)
@sentry/react 25.02 KB (0%)
@sentry/react (incl. Tracing) 36.46 KB (0%)
@sentry/vue 26.39 KB (0%)
@sentry/vue (incl. Tracing) 35.29 KB (0%)
@sentry/svelte 22.41 KB (0%)
CDN Bundle 23.5 KB (0%)
CDN Bundle (incl. Tracing) 35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.48 KB (0%)
CDN Bundle - uncompressed 68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.09 KB (0%)
@sentry/nextjs (client) 36.35 KB (0%)
@sentry/sveltekit (client) 34.07 KB (0%)
@sentry/node 130.84 KB (0%)
@sentry/node - without tracing 91.86 KB (0%)
@sentry/aws-serverless 117.03 KB (0%)

@andreiborza andreiborza merged commit aefbfaa into develop Jul 9, 2024
@andreiborza andreiborza deleted the ryan953/ref-12784-preact-imports branch July 9, 2024 07:28
This was referenced Jul 30, 2024
Open
Open
@amykapernick amykapernick mentioned this pull request Aug 1, 2024
Open
@wkylin wkylin mentioned this pull request Aug 1, 2024
Closed
@q1blue q1blue mentioned this pull request Aug 6, 2024
Open
@wkylin wkylin mentioned this pull request Aug 7, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
@q1blue q1blue mentioned this pull request Aug 9, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan953 @andreiborza