Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(nestjs): Automatic instrumentation of nestjs pipes #13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2024
Merged

feat(nestjs): Automatic instrumentation of nestjs pipes #13137

merged 2 commits into from
Aug 1, 2024

Conversation

nicohrubec
Copy link
Contributor

@nicohrubec nicohrubec commented Jul 31, 2024 •
edited
Loading

Adds automatic instrumentation of pipes to @sentry/nestjs. Pipes in nest have a @Injectable decorator and implement a transform function. So we can simply extend the existing instrumentation to add a proxy for transform.

Screenshot from sample app:
Screenshot 2024-07-31 at 15 36 45

@nicohrubec nicohrubec linked an issue Jul 31, 2024 that may be closed by this pull request
Instrumentation of NestJS pipes #13121
Closed
@nicohrubec nicohrubec self-assigned this Jul 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.45 KB (0%)
@sentry/browser (incl. Tracing) 34.22 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.62 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.26 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.11 KB (0%)
@sentry/browser (incl. metrics) 26.75 KB (0%)
@sentry/browser (incl. Feedback) 39.37 KB (0%)
@sentry/browser (incl. sendFeedback) 27.06 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.7 KB (0%)
@sentry/react 25.22 KB (0%)
@sentry/react (incl. Tracing) 37.22 KB (0%)
@sentry/vue 26.6 KB (0%)
@sentry/vue (incl. Tracing) 36.06 KB (0%)
@sentry/svelte 22.58 KB (0%)
CDN Bundle 23.64 KB (0%)
CDN Bundle (incl. Tracing) 35.88 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.57 KB (0%)
CDN Bundle - uncompressed 69.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.16 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.99 KB (0%)
@sentry/nextjs (client) 37.07 KB (-0.04% 🔽)
@sentry/sveltekit (client) 34.79 KB (-0.06% 🔽)
@sentry/node 114.67 KB (+0.11% 🔺)
@sentry/node - without tracing 89.33 KB (+0.01% 🔺)
@sentry/aws-serverless 98.5 KB (0%)

@nicohrubec nicohrubec marked this pull request as ready for review July 31, 2024 14:13
lforst
lforst approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nicohrubec nicohrubec merged commit bfb7ec4 into develop Aug 1, 2024
@nicohrubec nicohrubec deleted the nh/instrument-nest-pipes branch August 1, 2024 08:25
@q1blue q1blue mentioned this pull request Aug 27, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 27, 2024
Closed
@voidedstarlight voidedstarlight mentioned this pull request Aug 27, 2024
Closed
This was referenced Aug 27, 2024
Open
Merged
@sleidig sleidig mentioned this pull request Aug 27, 2024
Closed
@tomwwinter tomwwinter mentioned this pull request Aug 27, 2024
Closed
@aam-digital-ci aam-digital-ci mentioned this pull request Aug 27, 2024
Closed
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 27, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Aug 28, 2024
Closed
This was referenced Aug 28, 2024
Open
Open
@q1blue q1blue mentioned this pull request Aug 28, 2024
Open
This was referenced Aug 29, 2024
Open
Open
@sleidig sleidig mentioned this pull request Aug 29, 2024
Closed
@gokulk16 gokulk16 mentioned this pull request Aug 30, 2024
Merged
@angeloreale angeloreale mentioned this pull request Aug 30, 2024
Open
@angeloreale angeloreale mentioned this pull request Aug 30, 2024
Open
This was referenced Aug 30, 2024
Closed
Closed
@q1blue q1blue mentioned this pull request Aug 30, 2024
Open
@angeloreale angeloreale mentioned this pull request Aug 31, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 1, 2024
Closed
@PierreGode PierreGode mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Closed
Closed
@q1blue q1blue mentioned this pull request Sep 7, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 8, 2024
Closed
@bagulm123 bagulm123 mentioned this pull request Sep 8, 2024
Open
@KeeghanM KeeghanM mentioned this pull request Sep 12, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome Awaiting requested review from chargome

@andreiborza andreiborza Awaiting requested review from andreiborza

1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nicohrubec nicohrubec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrumentation of NestJS pipes
2 participants
@nicohrubec @lforst