Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(opentelemetry): Do not overwrite http span name if kind is internal #13282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix(opentelemetry): Do not overwrite http span name if kind is internal #13282

merged 3 commits into from
Aug 12, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 8, 2024

If the kind of a http span is neither client nor server, it implies it is most likely being started with startSpan() manually, in which case we rather not want to overwrite the name.

@mydea mydea self-assigned this Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.47 KB (0%)
@sentry/browser (incl. Tracing) 34.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.65 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.71 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.33 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.17 KB (0%)
@sentry/browser (incl. metrics) 26.77 KB (0%)
@sentry/browser (incl. Feedback) 39.42 KB (0%)
@sentry/browser (incl. sendFeedback) 27.09 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.75 KB (0%)
@sentry/react 25.24 KB (0%)
@sentry/react (incl. Tracing) 37.25 KB (0%)
@sentry/vue 26.62 KB (0%)
@sentry/vue (incl. Tracing) 36.1 KB (0%)
@sentry/svelte 22.61 KB (0%)
CDN Bundle 23.69 KB (0%)
CDN Bundle (incl. Tracing) 35.94 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.62 KB (0%)
CDN Bundle - uncompressed 69.52 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.45 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.19 KB (0%)
@sentry/nextjs (client) 37.11 KB (0%)
@sentry/sveltekit (client) 34.82 KB (0%)
@sentry/node 115.51 KB (+0.04% 🔺)
@sentry/node - without tracing 89.91 KB (+0.06% 🔺)
@sentry/aws-serverless 99.34 KB (+0.04% 🔺)

@mydea mydea force-pushed the fn/node-infer-http branch from 08bcef6 to 1390457 Compare August 12, 2024 09:29
@mydea mydea mentioned this pull request Aug 12, 2024
Merged
mydea added a commit that referenced this pull request Aug 12, 2024
@mydea
fix(remix): Ensure origin is correctly set for remix server spans (#…
16996bb 
…13305)

Noticed here: #13282
that we are not correctly setting origin for remix spans.
@mydea mydea force-pushed the fn/node-infer-http branch from 1390457 to 4b9bfa0 Compare August 12, 2024 10:47
@mydea mydea merged commit 51bbf32 into develop Aug 12, 2024
@mydea mydea deleted the fn/node-infer-http branch August 12, 2024 11:05
This was referenced Sep 4, 2024
Closed
Closed
@q1blue q1blue mentioned this pull request Sep 7, 2024
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 8, 2024
Closed
@bagulm123 bagulm123 mentioned this pull request Sep 8, 2024
Open
@KeeghanM KeeghanM mentioned this pull request Sep 12, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
@onsails onsails mentioned this pull request Sep 18, 2024
Open
@mohamed-helmy22020 mohamed-helmy22020 mentioned this pull request Sep 18, 2024
Open
@gokulk16 gokulk16 mentioned this pull request Sep 23, 2024
Closed
@q1blue q1blue mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Closed
Closed
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 27, 2024
Closed
This was referenced Sep 27, 2024
Open
Open
@bagulm123 bagulm123 mentioned this pull request Oct 1, 2024
Open
@q1blue q1blue mentioned this pull request Oct 1, 2024
Open
@KeeghanM KeeghanM mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

@andreiborza andreiborza Awaiting requested review from andreiborza

+1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @lforst @Lms24