test(nuxt): Add test for distributed client-to-server request#16788
Merged
test(nuxt): Add test for distributed client-to-server request#16788
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
77bbd04 to
6c89f3b
Compare
21078dc to
2be99a2
Compare
chargome
approved these changes
Jul 8, 2025
Member
chargome
left a comment
There was a problem hiding this comment.
Just left the comments on the first test but I this applies to all of them basically.
Rest LGTM!
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/tests/tracing.test.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/tests/tracing.test.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on route parametrization, it came up in this PR that there are different transactions/spans which should be parametrized:
pageloadtransaction -> it's already parametrized because of thevueIntegrationhttp.servertransaction -> not parametrizedhttp.clientspan when doing an extra server request -> not parametrizedhttp.serverspan when doing an extra server request -> not parametrizedThis test is added to have a visualization of the current state of parametrization to be able to iterate on it.
The PR is quite long but the test case and the tests are just copy-pasted to all Nuxt E2E tests.