feat(react-router): Ensure http.server route handling is consistent#16986
feat(react-router): Ensure http.server route handling is consistent#16986
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| processEvent(event) { | ||
| // Express generates bogus `*` routes for data loaders, which we want to remove here | ||
| // we cannot do this earlier because some OTEL instrumentation adds this at some unexpected point | ||
| if ( | ||
| event.type === 'transaction' && | ||
| event.contexts?.trace?.data && | ||
| event.contexts.trace.data[ATTR_HTTP_ROUTE] === '*' && | ||
| // This means the name has been adjusted before, but the http.route remains, so we need to remove it | ||
| event.transaction !== 'GET *' && | ||
| event.transaction !== 'POST *' | ||
| ) { | ||
| // eslint-disable-next-line @typescript-eslint/no-dynamic-delete | ||
| delete event.contexts.trace.data[ATTR_HTTP_ROUTE]; | ||
| } | ||
|
|
||
| return event; |
There was a problem hiding this comment.
Don't we also need to update the tx name here?
There was a problem hiding this comment.
this is done already in the respective place via updateSpanName, that forces a name over infernal. All we need to do here is remove the route attribute, as that can be misleading in product I think. (E2E tests should show this works xD)
927c18a to
ef814f8
Compare
There was a problem hiding this comment.
Bug: Undefined Data Access Causes Fallback Failure
A TypeError can occur when accessing spanData.data[SEMATTRS_HTTP_TARGET] if spanData.data is undefined. This prevents the intended fallback (e.g., url.pathname) from being evaluated.
packages/react-router/src/server/wrapServerAction.ts#L47-L48
packages/react-router/src/server/wrapServerLoader.ts#L48-L49
packages/react-router/src/server/instrumentation/reactRouter.ts#L91-L92
Bug: Route Handling Bug in React Router Integration
The processEvent method in reactRouterServerIntegration incorrectly handles bogus * routes. It only removes the http.route attribute when the transaction name is not "GET *" or "POST *", failing to address cases where the transaction name remains "GET *" or "POST *". This leaves transactions with unhelpful * names and http.route attributes, contradicting the intended goal of removing them and missing a case previously handled by older logic that updated the transaction name.
packages/react-router/src/server/integration/reactRouterServer.ts#L32-L49
Was this report helpful? Give feedback by reacting with 👍 or 👎
This updates react router http.server handling to ensure:
*transaction name by just usingprocessEventin the integration. This means we now always add the server integration, it just does less in non-matching node versions.