Codestin Search App

s1gr1d · 2025-07-21T10:45:27Z

Route Parametrization for Server Requests in Astro 5.

The route information is gathered during build-time. During runtime, the route information is matched to use the parametrized route information during runtime

Part of #16686

Lms24

Just a few questions -- nice work!

Lms24 · 2025-07-21T11:09:23Z

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.dynamic.test.ts

    // Server HTTP request transaction - should be parametrized (todo: currently not parametrized)
    expect(serverHTTPServerRequestTxn).toMatchObject({
-      transaction: 'GET /api/user/myUsername123.json', // todo: should be parametrized to 'GET /api/user/[userId].json'
+      transaction: 'GET /api/user/[userId].json',


l: Is there a test that ensures that a known route like GET / api/user/settings.json? Just wanna make sure we can disambiguate these routes :)

not yet, but I was thinking about that!

In this case, it would work as user/settings and user/someID can be differentiated easily by matching the routePattern. routePattern will be user/settings or user/[userid] (all lowercased).

packages/astro/src/server/middleware.ts

Lms24 · 2025-07-21T11:15:46Z

packages/astro/src/server/middleware.ts

+        const interpolatedRoute =
+          foundRoute?.patternCaseSensitive || interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params);


also just so that I understand correctly: The ctx.routePattern alone is case-insensitive and we use the build time-injected information so that we get the case-sensitive one?

Lms24

Thanks for clarifying!
(I'll leave reviewing the cursor stuff up to you. Pretty sure some of the findings don't apply).

s1gr1d · 2025-07-21T12:43:16Z

Addressing cursor comments:

The includeRouteDataToConfigFile function repeatedly appends route information

That's no problem during build-time as the hook is only called once. During runtime I'll add a variable to make sure it only runs once.

The route.pattern property within storedBuildTimeRoutes is incorrectly serialized to {}

That's why I am appending .source of the regex to get the stringified value

joinRouteSegments() incorrectly processes catch-all route segments

No because the .content of the segment includes the ... like ...path

The rawRoutePattern variable is always undefined

No, only Astro version lower than 5

cursor

Bug: Sentry Route Info Repeatedly Appended

The astro:routes:resolved hook unconditionally appends globalThis["__sentryRouteInfo"] to the user's server init file. The didSaveRouteData flag only prevents multiple writes within a single build process, causing route information to be repeatedly appended across multiple builds. This leads to file bloat, duplicate assignments, and potential JavaScript syntax errors or unexpected runtime behavior.

packages/astro/src/integration/index.ts#L174-L203

sentry-javascript/packages/astro/src/integration/index.ts

Lines 174 to 203 in b4ec0f7

    
                 // @ts-expect-error - This hook is available in Astro 5+ 
        
                 'astro:routes:resolved': ({ routes }: { routes: IntegrationResolvedRoute[] }) => { 
        
                   if (!sentryServerInitPath || didSaveRouteData) { 
        
                     return; 
        
                   } 
        
                   try { 
        
                     const serverInitContent = readFileSync(sentryServerInitPath, 'utf8'); 
        
                     const updatedServerInitContent = `${serverInitContent}\nglobalThis["__sentryRouteInfo"] = ${JSON.stringify( 
        
                       routes.map(route => { 
        
                         return { 
        
                           ...route, 
        
                           patternCaseSensitive: joinRouteSegments(route.segments), // Store parametrized routes with correct casing on `globalThis` to be able to use them on the server during runtime 
        
                           patternRegex: route.patternRegex.source, // using `source` to be able to serialize the regex 
        
                         }; 
        
                       }), 
        
                       null, 
        
                       2, 
        
                     )};`; 
        
                     writeFileSync(sentryServerInitPath, updatedServerInitContent, 'utf8'); 
        
                     didSaveRouteData = true; // Prevents writing the file multiple times during runtime 
        
                     debug.log('Successfully added route pattern information to Sentry config file:', sentryServerInitPath); 
        
                   } catch (error) { 
        
                     debug.warn(`Failed to write to Sentry config file at ${sentryServerInitPath}:`, error); 
        
                   } 
        
                 },

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

) Route Parametrization for Server Requests in Astro 5. The route information is gathered during build-time. During runtime, the route information is matched to use the parametrized route information during runtime Part of #16686

Backport of all server-related parametrization in Astro: - #17054 - #17085 - #17102 - #17105

feat(astro): Server Request Route Parametrization

5e48038

s1gr1d force-pushed the sig/astro-5-route-param branch from 72df08c to 5e48038 Compare July 21, 2025 10:48

s1gr1d changed the title ~~feat(astro): Server Request Route Parametrization~~ feat(astro): Implement Request Route Parametrization for Astro 5 Jul 21, 2025

s1gr1d requested review from Lms24 and mydea July 21, 2025 10:53

refactor functions

abf9b5f

Lms24 reviewed Jul 21, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Lms24 approved these changes Jul 21, 2025

View reviewed changes

s1gr1d added 2 commits July 21, 2025 14:46

add test, some refactoring and fixes

3a36e1a

delete line

78dff8a

This comment was marked as outdated.

Sign in to view

s1gr1d and others added 2 commits July 21, 2025 14:50

remove outdated comments

94e18a7

Merge branch 'develop' into sig/astro-5-route-param

b4ec0f7

cursor bot reviewed Jul 21, 2025

View reviewed changes

s1gr1d merged commit 726c868 into develop Jul 21, 2025
145 of 146 checks passed

s1gr1d deleted the sig/astro-5-route-param branch July 21, 2025 13:57

s1gr1d mentioned this pull request Jul 24, 2025

feat(v9/astro): Parametrize dynamic server routes #17141

Merged

s1gr1d added a commit that referenced this pull request Jul 24, 2025

feat(v9/astro): Parametrize dynamic server routes (#17141)

dac0aff

Backport of all server-related parametrization in Astro: - #17054 - #17085 - #17102 - #17105

This was referenced Sep 29, 2025

Bump @sentry/react from 8.55.0 to 10.16.0 Pouria-FOSSA/dependabot-metadata-test#65

Closed

Bump @sentry/react from 8.55.0 to 10.17.0 Pouria-FOSSA/dependabot-metadata-test#66

Closed

This was referenced Oct 7, 2025

Bump @sentry/react from 8.55.0 to 10.18.0 Pouria-FOSSA/dependabot-metadata-test#68

Closed

Bump @sentry/react from 8.55.0 to 10.19.0 Pouria-FOSSA/dependabot-metadata-test#70

Closed

This was referenced Oct 15, 2025

Bump @sentry/react from 8.55.0 to 10.20.0 Pouria-FOSSA/dependabot-metadata-test#71

Closed

Bump @sentry/react from 8.55.0 to 10.21.0 Pouria-FOSSA/dependabot-metadata-test#72

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(astro): Implement Request Route Parametrization for Astro 5#17105

feat(astro): Implement Request Route Parametrization for Astro 5#17105
s1gr1d merged 6 commits intodevelopfrom
sig/astro-5-route-param

s1gr1d commented Jul 21, 2025

Uh oh!

Lms24 left a comment

Uh oh!

Lms24 Jul 21, 2025

Uh oh!

s1gr1d Jul 21, 2025

Uh oh!

Uh oh!

Lms24 Jul 21, 2025

Uh oh!

s1gr1d Jul 21, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Lms24 left a comment

Uh oh!

s1gr1d commented Jul 21, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const interpolatedRoute =
		foundRoute?.patternCaseSensitive \|\| interpolateRouteFromUrlAndParams(ctx.url.pathname, ctx.params);


	// @ts-expect-error - This hook is available in Astro 5+
	'astro:routes:resolved': ({ routes }: { routes: IntegrationResolvedRoute[] }) => {
	if (!sentryServerInitPath \|\| didSaveRouteData) {
	return;
	}

	try {
	const serverInitContent = readFileSync(sentryServerInitPath, 'utf8');

	const updatedServerInitContent = `${serverInitContent}\nglobalThis["__sentryRouteInfo"] = ${JSON.stringify(
	routes.map(route => {
	return {
	...route,
	patternCaseSensitive: joinRouteSegments(route.segments), // Store parametrized routes with correct casing on `globalThis` to be able to use them on the server during runtime
	patternRegex: route.patternRegex.source, // using `source` to be able to serialize the regex
	};
	}),
	null,
	2,
	)};`;

	writeFileSync(sentryServerInitPath, updatedServerInitContent, 'utf8');

	didSaveRouteData = true; // Prevents writing the file multiple times during runtime
	debug.log('Successfully added route pattern information to Sentry config file:', sentryServerInitPath);
	} catch (error) {
	debug.warn(`Failed to write to Sentry config file at ${sentryServerInitPath}:`, error);
	}
	},

Uh oh!

Conversation

s1gr1d commented Jul 21, 2025

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

Lms24 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lms24 Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

s1gr1d Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Lms24 left a comment

Choose a reason for hiding this comment

Uh oh!

s1gr1d commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Sentry Route Info Repeatedly Appended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

s1gr1d commented Jul 21, 2025 •

edited

Loading