ref(core): Extract and reuse getCombinedScopeData helper#18585
Merged
ref(core): Extract and reuse getCombinedScopeData helper#18585
getCombinedScopeData helper#18585Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Member
Author
|
hmm not fully sure about the bundle size measurements here tbh. It makes sense that it slightly increases for the minimal npm package config (1 occurance) and then again decreases if you add logs or metrics (2 occurances). Not sure why adding logs AND metrics (3 occurances) actually increases size again 🤔 |
getFinalScopeData helpergetCombinedScopeData helper
chargome
approved these changes
Dec 29, 2025
logaretm
pushed a commit
that referenced
this pull request
Jan 8, 2026
Pre-work for #18160 We have multiple places in which we need to combine the `ScopeData` of global, isolation and current scopes, to apply this data to telemetry items (events, logs, metrics, soon also spansV2). Previously, we did this in-place or with helpers that were not re-used. This PR now unifies the various locations to one helper from core which can be reused everywhere. Closes #18586 (added automatically)
logaretm
pushed a commit
that referenced
this pull request
Jan 8, 2026
Pre-work for #18160 We have multiple places in which we need to combine the `ScopeData` of global, isolation and current scopes, to apply this data to telemetry items (events, logs, metrics, soon also spansV2). Previously, we did this in-place or with helpers that were not re-used. This PR now unifies the various locations to one helper from core which can be reused everywhere. Closes #18586 (added automatically)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-work for #18160
We have multiple places in which we need to combine the
ScopeDataof global, isolation and current scopes, to apply this data to telemetry items (events, logs, metrics, soon also spansV2). Previously, we did this in-place or with helpers that were not re-used. This PR now unifies the various locations to one helper from core which can be reused everywhere.Closes #18586 (added automatically)