Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): Set op on ended Vercel AI spans#18601

Merged
RulaKhaled merged 4 commits intodevelopfrom
rolaabuhasna/js-1280-vercelaiintegration-span-op-stays-default-instead-of-2
Dec 30, 2025
Merged

fix(core): Set op on ended Vercel AI spans#18601
RulaKhaled merged 4 commits intodevelopfrom
rolaabuhasna/js-1280-vercelaiintegration-span-op-stays-default-instead-of-2

Conversation

@RulaKhaled
Copy link
Member

@RulaKhaled RulaKhaled commented Dec 22, 2025

Ensures Vercel AI span op is always set correctly at span start, regardless of whether the model ID is available.

Changes:

  • Removed the model ID check gate before calling processGenerateSpan - the op is determined by span name, not model ID
  • Span name updates (e.g., generate_text gpt-4) are now only applied when model ID exists, avoiding undefined in names
  • Added integration test for late model ID scenario

Closes #18448

@linear
Copy link

linear bot commented Dec 22, 2025

JS-1280 vercelAIIntegration: span op stays 'default' instead of 'gen_ai.invoke_agent' - AI Agents dashboard shows no data

This was referenced Dec 22, 2025
Closed
Closed
cursor[bot]
cursor bot reviewed Dec 22, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.84 kB - -
@sentry/browser - with treeshaking flags 23.34 kB - -
@sentry/browser (incl. Tracing) 41.62 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.21 kB - -
@sentry/browser (incl. Tracing, Replay) 80.19 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.93 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84.87 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 97.12 kB - -
@sentry/browser (incl. Feedback) 41.56 kB - -
@sentry/browser (incl. sendFeedback) 29.53 kB - -
@sentry/browser (incl. FeedbackAsync) 34.52 kB - -
@sentry/browser (incl. Metrics) 25.87 kB - -
@sentry/browser (incl. Logs) 26.09 kB - -
@sentry/browser (incl. Metrics & Logs) 26.75 kB - -
@sentry/react 26.56 kB - -
@sentry/react (incl. Tracing) 43.81 kB +0.01% +4 B 🔺
@sentry/vue 29.3 kB - -
@sentry/vue (incl. Tracing) 43.43 kB - -
@sentry/svelte 24.85 kB - -
CDN Bundle 27.27 kB - -
CDN Bundle (incl. Tracing) 42.26 kB - -
CDN Bundle (incl. Tracing, Replay) 78.97 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 84.42 kB - -
CDN Bundle - uncompressed 80.08 kB - -
CDN Bundle (incl. Tracing) - uncompressed 125.51 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 242.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.81 kB - -
@sentry/nextjs (client) 46.04 kB - -
@sentry/sveltekit (client) 41.99 kB - -
@sentry/node-core 51.66 kB - -
@sentry/node 161.58 kB +0.02% +22 B 🔺
@sentry/node - without tracing 93.09 kB - -
@sentry/aws-serverless 108.6 kB - -

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,375 - 8,930 +5%
GET With Sentry 1,745 19% 1,709 +2%
GET With Sentry (error only) 6,080 65% 6,144 -1%
POST Baseline 1,177 - 1,193 -1%
POST With Sentry 584 50% 595 -2%
POST With Sentry (error only) 1,048 89% 1,059 -1%
MYSQL Baseline 3,312 - 3,326 -0%
MYSQL With Sentry 449 14% 455 -1%
MYSQL With Sentry (error only) 2,661 80% 2,675 -1%

View base workflow run

@RulaKhaled RulaKhaled requested a review from chargome December 22, 2025 12:42
chargome
chargome approved these changes Dec 22, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RulaKhaled RulaKhaled merged commit 5425ffb into develop Dec 30, 2025
206 checks passed
@RulaKhaled RulaKhaled deleted the rolaabuhasna/js-1280-vercelaiintegration-span-op-stays-default-instead-of-2 branch December 30, 2025 12:29
@github-actions github-actions bot mentioned this pull request Jan 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@chargome chargome chargome approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vercelAIIntegration: span op stays 'default' instead of 'gen_ai.invoke_agent' - AI Agents dashboard shows no data

2 participants

@RulaKhaled @chargome