ref(react-router): Use snake_case for span op names#18617
Merged
Conversation
2fdcb14 to
3134d5b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates span operation names in the react-router package from kebab-case to snake_case to comply with Sentry's telemetry specification for span operations. The changes ensure consistency across all loader and action span operations.
- Updated span operation names from
function.react-router.*tofunction.react_router.* - Applied changes consistently across source code, utilities, and all test files
- Maintained backward compatibility by only changing the naming convention
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/react-router/src/server/wrapServerLoader.ts |
Updated span op attribute to use function.react_router.loader |
packages/react-router/src/server/wrapServerAction.ts |
Updated span op attribute to use function.react_router.action |
packages/react-router/src/server/instrumentation/util.ts |
Updated all three return values in getOpName() to use snake_case |
packages/react-router/test/server/wrapServerLoader.test.ts |
Updated test expectations for loader span operations |
packages/react-router/test/server/wrapServerAction.test.ts |
Updated test expectations for action span operations |
dev-packages/e2e-tests/test-applications/react-router-7-framework/tests/performance/performance.server.test.ts |
Updated E2E test assertions for both loader and action span ops |
dev-packages/e2e-tests/test-applications/react-router-7-framework-node-20-18/tests/performance/performance.server.test.ts |
Updated E2E test assertions for both loader and action span ops |
dev-packages/e2e-tests/test-applications/react-router-7-framework-custom/tests/performance/performance.server.test.ts |
Updated E2E test assertions for both loader and action span ops |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 8, 2026
Lms24
pushed a commit
that referenced
this pull request
Jan 30, 2026
Following up: #18617 > The span ops should be using snake_case as per our spec: https://develop.sentry.dev/sdk/telemetry/traces/span-operations/ Closes #18730 (added automatically)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up while working on #18580
The span ops should be using snake_case as per our spec: https://develop.sentry.dev/sdk/telemetry/traces/span-operations/