fix(react,solid,vue): Fix parametrization behavior for non-matched routes#18735
Merged
andreiborza merged 1 commit intodevelopfrom Jan 8, 2026
Merged
fix(react,solid,vue): Fix parametrization behavior for non-matched routes#18735andreiborza merged 1 commit intodevelopfrom
andreiborza merged 1 commit intodevelopfrom
Conversation
…utes Our e2e tests started breaking around the `1.142.x` release of tanstack router, we ended up hard-pinning the version to `1.141.8`. The failures revealed a real behavioral change of matches tanstack router returns when attempting to match a non-existing route. Previously the matches would be an empty array, but we now get a `__root__` match. The fix involves checking if the last match is `__root__` and falling back to `url` for `sentry.source` attributes. Closes: #18672
s1gr1d
approved these changes
Jan 8, 2026
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our e2e tests started breaking around the
1.142.xrelease of tanstack router, we ended up hard-pinning the version to1.141.8.The failures revealed a real behavioral change of matches tanstack router returns when attempting to match a non-existing route.
Previously the matches would be an empty array, but we now get a
__root__match.The fix involves checking if the last match is
__root__and falling back tourlforsentry.sourceattributes.Closes: #18672