test(fastify): Verify if upstream error is fixed and won't regress#18838
Merged
test(fastify): Verify if upstream error is fixed and won't regress#18838
Conversation
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Show resolved
Hide resolved
nicohrubec
reviewed
Jan 16, 2026
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Outdated
Show resolved
Hide resolved
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
dev-packages/e2e-tests/test-applications/node-fastify-5/src/app-handle-error-override.ts
Show resolved
Hide resolved
nicohrubec
reviewed
Jan 16, 2026
dev-packages/e2e-tests/test-applications/node-fastify-5/src/app-handle-error-override.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Outdated
Show resolved
Hide resolved
39698b0 to
958d9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18418
closes JS-1260
A test that verifies that the upstream issue got fixed.
There was also one tiny config for playwright which was missed, so the wrong application was running.