chore(e2e): Add e2e claude skill#18957
Conversation
The nature of running e2e tests in our repo is particular: When making changes in an SDK, we need to rebuild that SDK and create its tarball, only then can we run the e2e test application. Agents lack this context and will often make changes, rebuild the SDK but not publish a tarball for example. This skill can be invoked via `/e2e <test-application-name>`, e.g. `/e2e nuxt-3` and it will detect and perform SDK rebuilds before running the e2e tests.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| ```bash | ||
| # Check which packages have uncommitted changes | ||
| git status --porcelain | grep "^[ MARC][ MD] packages/" | cut -d'/' -f2 | sort -u |
There was a problem hiding this comment.
Git command misses untracked new files in packages
Medium Severity
The git command grep "^[ MARC][ MD] packages/" only matches certain status codes but misses untracked files which use ??. When a developer adds a new file to an SDK package, it appears as ?? packages/node/newfile.ts in git status --porcelain output. Since ? is not in the character class [ MARC], these packages won't be detected as modified, causing the skill to skip rebuilding them. The E2E test would then run against stale code.
|
@andreiborza - I'm not sure if it's specific to my local setup, but I need to run |
|
@onurtemizkan hm I don't have this issue. I'm not sure if others have either, maybe that's something specific to your setup? |
The nature of running e2e tests in our repo is particular: When making changes in an SDK, we need to rebuild that SDK and create its tarball, only then can we run the e2e test application.
Agents lack this context and will often make changes, rebuild the SDK but not publish a tarball for example.
This skill can be invoked via
/e2e <test-application-name>, e.g./e2e nuxt-3and it will detect and perform SDK rebuilds before running the e2e tests.