-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(deps): Bump trpc v11 dependecy in e2e test #19061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "@trpc/server": "~11.3.0", | ||
| "@trpc/client": "~11.8.0", | ||
| "@trpc/react-query": "~11.8.0", | ||
| "@trpc/server": "~11.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The tRPC dependency bump to ~11.8.0 requires @tanstack/react-query version ^5.80.3, but the package.json specifies an incompatible older version, ^5.50.0.
Severity: MEDIUM
Suggested Fix
In package.json, update the version for the @tanstack/react-query dependency to satisfy the new peer dependency requirement. Change the constraint from ^5.50.0 to ^5.80.3.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: dev-packages/e2e-tests/test-applications/nextjs-t3/package.json#L22
Potential issue: The update of `@trpc/react-query` to version `~11.8.0` introduces a
peer dependency requirement for `@tanstack/react-query` version `^5.80.3`. The project's
`package.json` currently specifies a lower compatible version, `^5.50.0`. This mismatch
may not cause an installation failure but can lead to runtime errors. These errors would
occur if the updated tRPC package calls APIs from `@tanstack/react-query` that were
introduced after version `5.50.0` but before `5.80.3`, leading to unexpected behavior or
crashes within the test application.
Did we get this right? 👍 / 👎 to inform future reviews.
closes https://github.com/getsentry/sentry-javascript/security/dependabot/900
Closes #19067 (added automatically)